Skip to content

Conversation

alexcrichton
Copy link
Member

This was an accidental regression from #56092, but for no_std targets
being built and distributed we want to be sure to activate the
compiler-builtins mem feature which demangles important memory-related
intrinsics.

This was an accidental regression from rust-lang#56092, but for `no_std` targets
being built and distributed we want to be sure to activate the
compiler-builtins `mem` feature which demangles important memory-related
intrinsics.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2018
@alexcrichton
Copy link
Member Author

@bors: p=1

(fixing a regression)

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 14, 2018

📌 Commit c811915 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2018
@bors
Copy link
Collaborator

bors commented Dec 15, 2018

⌛ Testing commit c811915 with merge bcf920f...

bors added a commit that referenced this pull request Dec 15, 2018
std: Activate compiler_builtins `mem` feature for no_std targets

This was an accidental regression from #56092, but for `no_std` targets
being built and distributed we want to be sure to activate the
compiler-builtins `mem` feature which demangles important memory-related
intrinsics.
@bors
Copy link
Collaborator

bors commented Dec 15, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing bcf920f to master...

@bors bors merged commit c811915 into rust-lang:master Dec 15, 2018
@alexcrichton alexcrichton deleted the demangle-mem branch December 17, 2018 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants